Slycot source uses setuptools_scm now #751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
027aebd to
0ff9191
Compare
|
@bnavigator This PR looks fine, but I note that it now builds against that latest Slycot in available via pip, versus the previous behavior which checked against the latest version on github. |
|
Are you sure? This is the latest version on github. |
|
Ah, I see now. I was confused about how the repository was being check out. I agree the behavior is unchanged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python-control/Slycot#180 broke the CI setup for the tests with a Slycot from latest sources (0.5.1.dev6 at the moment).
Given that the change blocks proper CI runs in PRs like #750, I intend to merge this as soon as the CI passes.