Fix timebase bug in InterconnectedSystem (issue #754) #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Conda-based builds are failing. I checked and this is also happening on the current main branch. This may be something associated with Slycot 0.5.0?? |
| (None, 0.1, 0.1), | ||
| (None, None, None), | ||
| (0.2, None, 0.2), | ||
| (0.2, 0.1, ValueError), |
There was a problem hiding this comment.
Great PR. Would be good to add tests for dt=True, which are compatible with all other discrete-time timebases. https://python-control.readthedocs.io/en/0.9.2/conventions.html
229bfe6 to
cf30479
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the timebase bug identified in issue #754. The fix was to modify the processing of the timebase in
InterconnectedSystemso that it looks at the systems for the default timebase.