Skip to content

Feature: allow differing numerator and denominator degree in Pade app… #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2016

Conversation

roryyorke
Copy link
Contributor

Intended to be simple-as-possible implementation (or at least, as-close-to-previous-as-possible).

I've added tests - couldn't find any existing ones.

…rox.

As suggested by @jason-s in python-control#73

This is a relatively minimal change, and should do no worse and no
better than the previous implementation when numerator and denominator
have equal degree.
@slivingston slivingston self-assigned this Jan 5, 2016
@slivingston
Copy link
Member

@jason-s or anyone, Is there a DOI or more complete reference for the paper by Vajta? The URL in #73 is directly to the author's website, and my brief search did not yield results.

@jason-s
Copy link

jason-s commented Mar 7, 2016

@slivingston I am not sure there is another online source; everyone citing Vajta seems to refer to the author's website.

@jason-s
Copy link

jason-s commented Mar 7, 2016

Well, you could cite ResearchGate's copy: https://www.researchgate.net/publication/229003251_Some_remarks_on_Pade-approximations

@jason-s
Copy link

jason-s commented Mar 7, 2016

Other references are:

Moler, Cleve, and Charles Van Loan. "Nineteen dubious ways to compute the exponential of a matrix, twenty-five years later." SIAM review 45.1 (2003): 3-49. http://www.cs.cornell.edu/cv/researchpdf/19ways+.pdf or the original (1978) at http://citeseerx.ist.psu.edu/viewdoc/summary?doi=10.1.1.129.9283

Hanta, V., and A. Procházka. "Rational approximation of time delay." Institute of Chemical Technology in Prague. Department of computing and control engineering. Technická 5.166 (2009): 28. http://www2.humusoft.cz/www/papers/tcp09/035_hanta.pdf

@slivingston
Copy link
Member

@roryyorke The proposed changes and additions are good. In delay_test.py, you write "...ideally test to numerical limits". Could you comment how that may be achieved as future work?

Thanks, @jason-s. I will add the references to the docstring of pade() after merging.

slivingston added a commit that referenced this pull request Mar 8, 2016
Feature: allow differing numerator and denominator degree in Padé approximations
@slivingston slivingston merged commit 0b26e06 into python-control:master Mar 8, 2016
@roryyorke
Copy link
Contributor Author

@slivingston there are two possible extremes I can think of: large order (according to @jason-s 's article [1], maximum is n=21), and very large and small T (obviously with order 20 and T=1e16 result is going to overflow - not sure if there are numerical issues for more realistic but still large T).

I think this PR closes #73 ?

[1] http://www.embeddedrelated.com/showarticle/927.php

@roryyorke roryyorke deleted the rory-pade-spec-num branch January 5, 2019 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants