fix _isstatic() to use nstates==0 #790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roryyorke
reviewed
Nov 13, 2022
| @@ -51,7 +54,7 @@ class TSys: | |||
| def test_linear_iosys(self, tsys): | |||
| # Create an input/output system from the linear system | |||
| linsys = tsys.siso_linsys | |||
| iosys = ios.LinearIOSystem(linsys) | |||
| iosys = ios.LinearIOSystem(linsys).copy() | |||
There was a problem hiding this comment.
is it obvious why this .copy is necessary?
There was a problem hiding this comment.
Definitely not obvious, but this gets rid of a warning later on since the interconnect function generates a warning if a system appears more than once in an interconnected system, since then the name of system is not unique. (It's also possible to turn the warning off with warn_dupicate=False).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issues identified in PR #785 regarding the way that
StateSpace._isstaticwas defining a static system. New version requiresnstates == 0.