Skip to content

Fix find_eqpt when y0 is None #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2022
Merged

Fix find_eqpt when y0 is None #798

merged 1 commit into from
Nov 26, 2022

Conversation

adswid
Copy link
Contributor

@adswid adswid commented Nov 24, 2022

When y0 is None, dy in the root function should not be calculated (since it tries to subtract NoneType). In general, when y0 is None, the evaluation of the output function is not necessary.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 94.842% when pulling 57ad2f1 on adswid:fix-find_eqpt into 832527d on python-control:main.

@murrayrm
Copy link
Member

murrayrm commented Nov 26, 2022 •
edited
Loading

LGTM. Thanks for the fix, @adswid!

@murrayrm murrayrm merged commit 23a7791 into python-control:main Nov 26, 2022
@murrayrm murrayrm added this to the 0.9.3 milestone Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.3
Development

Successfully merging this pull request may close these issues.
3 participants
@adswid @coveralls @murrayrm