add zpk() function #816
Merged
add zpk() function #816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7983829 to
a123f15
Compare
a123f15 to
7ee0c0e
Compare
bnavigator
approved these changes
Dec 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the function
zpk, which creates a transfer function (as aNamedIOSystem) from a zero, pole, gain representation. This responds to issue #749.Also added in code to make sure that signal names are copied correctly in various conversions, removing some comments entered in PR #804. In
_convert_to_transfer_functionthis involved removing renaming from the low level function, as documented in the comment string.Notes:
Unlike in MATLAB and SciPy, which have zpk classes, here we just create a transfer function from the zpk data. That seems like the most common use case.
In the
matlabmodule there are also functionszpk2ssandzpk2tfthat implement lower level behavior (eg, zpk2ss returns A, B, C, D). This is similar to MATLAB. if you want to get aStateSpacesystem from a zpk representation, usesys = ct.ss(ct.zpk(zeros, poles, gain)).Unit tests and updated documentation are also included.