Skip to content

Fix Interconnect name clobbering #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2023
Merged

Fix Interconnect name clobbering #857

merged 1 commit into from
Feb 2, 2023

Conversation

henklaak
Copy link
Contributor

@henklaak henklaak commented Feb 1, 2023

iosys interconnect implementation clobbers the name argument of the function.
Fix by renaming to a name that is only used locally

@henklaak
Copy link
Contributor Author

henklaak commented Feb 1, 2023 •
edited
Loading

Fixes #848

Overlap with #849, but that one doesn't come with unittests ;-)

@coveralls
Copy link

Coverage Status

Coverage: 94.87%. Remained the same when pulling 5f2e758 on henklaak:main into 1f837a5 on python-control:main.

@bnavigator
Copy link
Contributor

Thanks. Will rebase #849.

@bnavigator bnavigator merged commit c4d1764 into python-control:main Feb 2, 2023
This was referenced Feb 2, 2023
Merged
Closed
@bnavigator bnavigator linked an issue Feb 2, 2023 that may be closed by this pull request
create_statefbk_iosystem sets system name incorrectly #848
Closed
@murrayrm murrayrm added this to the 0.9.4 milestone Mar 27, 2023
@murrayrm murrayrm mentioned this pull request May 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.4
Development

Successfully merging this pull request may close these issues.

create_statefbk_iosystem sets system name incorrectly
4 participants
@henklaak @coveralls @bnavigator @murrayrm