Skip to content

Solve #862 and #864: bode_plot phase wrapping incorrect for multiple systems #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 18, 2023
Merged

Solve #862 and #864: bode_plot phase wrapping incorrect for multiple systems #863

merged 5 commits into from
Feb 18, 2023

Conversation

henklaak
Copy link
Contributor

Function argument clobbered by local assignment. Use local variable instead.

@henklaak
Copy link
Contributor Author

henklaak commented Feb 17, 2023 •
edited
Loading

matplotlib 3.6.3 => 3.7.* seems to break our tests. Will investigate further.

@henklaak
Copy link
Contributor Author

Solves #862 and #864. If you prefer, I can make separate PRs.

@henklaak henklaak changed the title Solve #862: bode_plot phase wrapping incorrect for multiple systems Solve #862 and #864: bode_plot phase wrapping incorrect for multiple systems Feb 17, 2023
@coveralls
Copy link

Coverage Status

Coverage: 94.872%. Remained the same when pulling 4c4b3fc on henklaak:main into c4d1764 on python-control:main.

@murrayrm
Copy link
Member

Thanks for the fixes!

@murrayrm murrayrm merged commit 346bc40 into python-control:main Feb 18, 2023
This was referenced Feb 18, 2023
Closed
Closed
@murrayrm murrayrm added this to the 0.9.4 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.4
Development

Successfully merging this pull request may close these issues.
3 participants
@henklaak @coveralls @murrayrm