-
Notifications
You must be signed in to change notification settings - Fork 438
fix blank bode plot in rootlocus_pid_designer #883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I tried running this on the example I pointed out in #686 and when I click on the root locus, nothing changes. I then tried the same system in Also, why is 0.001 the right initial_gain to use? We have a default value for this ( |
Also, in looking at the code a bit, I am confused about the fact that the initial gain seems to be set using the |
Regarding default gain: for rootlocus-pid-designer, in principle you are already starting with baseline nonzero kd0, kp0, and ki0, and the step responses show result of that. You are interested in any addition delta-k to one of those, so it makes sense to start that one with a small value. But a zero value erases Bose plot. Np.eps is another option but it would make a very low gain bode plot so I picked a kind of arbitrary small nonzero value. |
Re non-interactive plot: doesn’t work in Jupiter, have to use magic command %matplotlib qt. Assuming you tried that, can you zoom? The way it works you have to click near one of its pre calculated points. It computes more if you zoom in. |
@murrayrm On further thought based on your questions, I realized that a deltaK parameter would be useful needed for non-interactive use, so that the bode plot was usable. Added it in. |
Using %matplotlib fixed the issues I was having, so I added a bit of documentation. |
Starts with a small gain rather than zero to insure that the frequency response plots appear. Addresses #686