Skip to content

warn if prewarp-frequency is not used #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2023
Merged

warn if prewarp-frequency is not used #900

merged 1 commit into from
Jun 3, 2023

Conversation

sawyerbfuller
Copy link
Contributor

This PR makes sure the prewarp-frequency kwarg is used in sys.sample.

  • now warns if a descretization type doesn't support it
  • now c2d is an identical copy of sample_system instead of being a somewhat-compatible version of it
  • more/better unit tests.

@sawyerbfuller
warn if prewarp-frequency is not used and tests, make c2d an identica…
29c9432 
…l copy to sample_system instead of a separate function
@coveralls
Copy link

Coverage Status

coverage: 94.623% (+0.003%) from 94.62% when pulling 29c9432 on sawyerbfuller:tustin-prewarp into fe4589b on python-control:main.

@murrayrm murrayrm merged commit 0c46562 into python-control:main Jun 3, 2023
@murrayrm murrayrm added this to the 0.9.4 milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.4
Development

Successfully merging this pull request may close these issues.
3 participants
@sawyerbfuller @coveralls @murrayrm