Skip to content

fix up some warning messages due to converted systems #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

murrayrm
Copy link
Member

@murrayrm murrayrm commented Jun 8, 2023

Small PR to fix up some issues where the functionality in #903 was causing some warning messages. In particular, the following snipped was causing a warning (from matlab_test.py):

siso_tf2 = tf([1, 1], [1, 2, 3, 1])
siso_ss2 = ss(siso_tf2)
[gm, pm, gmc, pmc] = margin(siso_ss2 * siso_ss2 * 2)

The reason for the warning was that siso_ss2 had the name 'sys[0]$converted' and when you create an interconnected system with duplicated non-generic names it gives you a warning (since things like change the parameters of one of the systems would affect the other.

To fix this, converted LinearIOSystems with "generic" names (sys[0]) do not get '$converted' added to the end. Instead they just get a new generic system name.

That change meant that some of the previous unit tests needed to use an explicitly named system, which is what the the changes in the unit tests are about.

@murrayrm murrayrm added this to the 0.9.4 milestone Jun 8, 2023
@coveralls
Copy link

Coverage Status

coverage: 94.628%. remained the same when pulling fb7a4a5 on murrayrm:fix_warnings-07Jun2023 into d834f7a on python-control:main.

@murrayrm murrayrm merged commit 56b9402 into python-control:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants