-
Notifications
You must be signed in to change notification settings - Fork 438
print a connection table for interconnected systems #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
aa9ef95
fix name of default name for duplcated system in interconnect
sawyerbfuller 5e92bb4
remove namedio from docstrings
sawyerbfuller 4e96553
add signal_table method to show implicit interconnections
sawyerbfuller b5925c3
unit test
sawyerbfuller 614de83
add signal_table function, test against show_names
sawyerbfuller 91aac8f
remove **kwargs
sawyerbfuller 796acad
switch docstring example to use system names
sawyerbfuller b787a9e
add tests for auto-sum and auto-split
sawyerbfuller c2b4480
rename function to connection_table, add option to change column width
sawyerbfuller 58e1b60
added field to interconnectedSystem and LinearICSystem to keep track …
sawyerbfuller 3637997
added connection_table to documentation in control.rst
sawyerbfuller 5c23f1a
change "(optional)" to ", optional" per numpydoc
murrayrm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1459,7 +1459,7 @@ class LinearICSystem(InterconnectedSystem, StateSpace): | |
|
||
""" | ||
|
||
def __init__(self, io_sys, ss_sys=None): | ||
def __init__(self, io_sys, ss_sys=None, connection_type=None): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a reason to allow the connection type to be overridden? It seems like this should just be inherited from the underlying |
||
# | ||
# Because this is a "hybrid" object, the initialization proceeds in | ||
# stages. We first create an empty InputOutputSystem of the | ||
|
@@ -1483,6 +1483,7 @@ def __init__(self, io_sys, ss_sys=None): | |
self.input_map = io_sys.input_map | ||
self.output_map = io_sys.output_map | ||
self.params = io_sys.params | ||
self.connection_type = connection_type | ||
|
||
# If we didnt' get a state space system, linearize the full system | ||
if ss_sys is None: | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't this correct before? Now it says 'a; or b; or c' instead of 'a; b; or c'.