-
Notifications
You must be signed in to change notification settings - Fork 438
Add pandas to pyproject.toml #964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pandas to pyproject.toml #964
Conversation
615e774
to
fa9dae2
Compare
I don't really see a big enough benefit of adding a single optional well known package with the same name as the package. What's the effective difference between |
FTR, I am guilty of starting that kind of extra with Slycot in #678. Probably would not do it again. |
You are right. There is no real difference. It was just for the sake of completeness. What do you think about a
or
https://hynek.me/articles/python-recursive-optional-dependencies/ I do not have strong feelings about it. I am OK not merging it. |
These are valid points, so I looked for other projects that use the pattern. I was able to find two well known packages:
The reason could be
Remark: |
Well, the benefits were not big enough. |
Adds pandas to pyproject.toml.
Allows optional install