Skip to content

Fix latest commit time #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 2, 2025
Merged

Fix latest commit time #89

merged 3 commits into from
May 2, 2025

Conversation

m-aciek
Copy link
Collaborator

@m-aciek m-aciek commented May 1, 2025

@StanFromIreland
Copy link
Collaborator

StanFromIreland commented May 1, 2025

In the build Korean has a last updated date of 2025/05/01 12:51:18, there was a new commit a short while ago (python/python-docs-ko@625f651) it would be good to test to see if it updates.

I worry rerunning may be pointless since it will ignore the saved clones I presume.

@m-aciek m-aciek marked this pull request as ready for review May 1, 2025 20:39
@m-aciek
Copy link
Collaborator Author

m-aciek commented May 1, 2025

I'm convinced this PR fixes the issue. In completion.py we've been checking out a commit from month ago for majority of languages. The repositories were in detached state after that and regular git checkout wasn't enough to go back to the previous state. In this PR the state is being restored directly after it's changed.

@m-aciek m-aciek merged commit 3b1efca into main May 2, 2025
4 checks passed
@m-aciek m-aciek deleted the latest-commit-time branch May 2, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clones are not updated
2 participants