-
Notifications
You must be signed in to change notification settings - Fork 671
Functional tests that create/update/delete resources are flaky #1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is not the only flaky test in these functional tests. Many of them fail randomly, but just in CI, never locally. I spend a lot of effort a while ago (even switched CI systems), but haven't figured it out, yet Or maybe we got to completely change this functional test setup, not sure. |
Ah I see :( I do get some failures locally, maybe my measly laptop is closer to Travis VM specs :P |
I now think that a lot of these failures happen when GitLab hands off tasks to Sidekiq asynchronously, and getting a response from the server does not mean that something is actually done (like deleting a project etc). If the next step/assert relies on that, it fails. I see this more often now as I try to convert asserts to test cases for #1024 (I will push that once it gets greener :P ). Especially as I try to delete a resource in teardown and re-create it for the next test. If I run tests with For example with the rate limit, if I try to reuse Have you or anyone here had any similar experience? Maybe we could have some kind of |
I realized the weird unrelated failure in #1020 (see https://travis-ci.org/python-gitlab/python-gitlab/jobs/652064210) was a flaky test for rate limits. I'm getting it locally sometimes but only rarely.
I haven't had the time to investigate but I'll try to have a look at some point. Maybe something in the environment slows down the requests sometimes and it does not trigger 429 or something.
The text was updated successfully, but these errors were encountered: