Skip to content

Duplicated code in gitlab/config.py #1094

Closed
@guiljin

Description

@guiljin

Description of the problem, including code/CLI snippet

Duplicated code found in gitlab/config.py . I think one should be get from 'global'.

        self.http_username = None
        self.http_password = None
        try:
            self.http_username = self._config.get(self.gitlab_id, "http_username")
            self.http_password = self._config.get(self.gitlab_id, "http_password")
        except Exception:
            pass

        self.http_username = None
        self.http_password = None
        try:
            self.http_username = self._config.get(self.gitlab_id, "http_username")
            self.http_password = self._config.get(self.gitlab_id, "http_password")
        except Exception:
            pass

Expected Behavior

Actual Behavior

Specifications

  • python-gitlab version: python-gitlab==2.2.0
  • API version you are using (v3/v4): v4
  • Gitlab server version (or gitlab.com):

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions