Skip to content

Fix snippet integration tests for GitLab 13.0 #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nejch opened this issue May 25, 2020 · 4 comments
Closed

Fix snippet integration tests for GitLab 13.0 #1105

nejch opened this issue May 25, 2020 · 4 comments
Assignees
@max-wittig
Labels
upstream

Comments

@nejch
Copy link
Member

nejch commented May 25, 2020

I was working on something unrelated and snippet tests kept failing.. turns out that when GitLab introduced versioned snippets in 13.0, along the way there's been some changes in the create/update API behavior that broke the functional tests (maybe this one https://gitlab.com/gitlab-org/gitlab/-/commit/ac3438f5c2a4da780e730660bccea5f4ac12483d).
@max-wittig max-wittig self-assigned this May 28, 2020
@max-wittig
Copy link
Member

This does look like a GitLab error. Renaming the snippet via API deletes it's contents.

@max-wittig
Copy link
Member

I reproduced it with curl and create an upstream issue: https://gitlab.com/gitlab-org/gitlab/-/issues/219348

@max-wittig
Copy link
Member

This will be fixed in 13.1. by GitLab. It would say we leave it in our tests like this for now or should we add allow_fail? @nejch

@nejch nejch mentioned this issue Oct 8, 2020
Merged
@nejch
Copy link
Member Author

nejch commented Oct 12, 2020

Looks like I forgot about this one, but the tests are included as of #1205 :)

@nejch nejch closed this as completed Oct 12, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@max-wittig max-wittig

Labels
upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@max-wittig @nejch