Skip to content

List groups only skips the last id provided in skip_groups #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
schuand opened this issue Dec 17, 2020 · 5 comments · Fixed by #1420
Closed

List groups only skips the last id provided in skip_groups #1256

schuand opened this issue Dec 17, 2020 · 5 comments · Fixed by #1420

Comments

@schuand
Copy link

schuand commented Dec 17, 2020

Description of the problem, including code/CLI snippet

The get groups endpoint returns a list of projects. When providing the parameter <skip_groups> the ids in the array should be skipped. The problem is that only the LAST id in the array is skipped.

Screenshot 2020-12-17 at 15 25 55

Expected Behavior

All groups that are provided in skip_groups should be skipped.

Actual Behavior

Only the group related to the last id in skip_groups is skipped.

Specifications

  • python-gitlab version: 2.5.0
  • API version you are using (v3/v4): v4
  • Gitlab server version (or gitlab.com): Gitlab server version
@max-wittig
Copy link
Member

Are you sure that you've provided the groups correctly?

Could you add a little snippet of your code here?

@schuand
Copy link
Author

schuand commented Dec 17, 2020

Screenshot 2020-12-17 at 16 36 51

Screenshot 2020-12-17 at 16 44 45

Screenshot 2020-12-17 at 16 37 07

@max-wittig
Copy link
Member

The variable skipped_projects, should contain group ids, not project ids

@schuand
Copy link
Author

schuand commented Dec 17, 2020 •
edited
Loading

Yes, the naming is bad. The ids are group ids.
The ids are valid and I can get the groups without problems. But I can't skip them.

@JohnVillalovos JohnVillalovos mentioned this issue Apr 26, 2021
Closed
@JohnVillalovos
Copy link
Member

At the moment, skip_groups must be a comma-delimited string, or a list of strings. It can't be a list of integers.

The root-cause for this issue is that the Gitlab API doesn't accept a list of integers at this time.

A work-around is being developed and progress tracked in: #1407

@JohnVillalovos JohnVillalovos mentioned this issue Apr 27, 2021
Closed
@nejch nejch mentioned this issue Apr 27, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(objects): make lists work for filters in all objects python-gitlab/python-gitlab
3 participants
@JohnVillalovos @max-wittig @schuand