Skip to content

Missing API code owner approval for protected branches #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
daniellanner opened this issue Apr 30, 2021 · 0 comments · Fixed by #1437
Closed

Missing API code owner approval for protected branches #1436

daniellanner opened this issue Apr 30, 2021 · 0 comments · Fixed by #1437

Comments

@daniellanner
Copy link
Contributor

Summary

The branch manager is missing an attribute implementation of code_owner_approval_required as documented in GitLab API documentation

Expected Behavior

ProjectProtectedBranchManager.code_owner_approval_required should be implemented to mirror the API as documented:

Attribute Type Required Description
code_owner_approval_required boolean no Prevent pushes to this branch if it matches an item in the CODEOWNERS file. (defaults: false)

Actual Behavior

code_owner_approval_required is not available as attribute in ProjectProtectedBranchManager.
@daniellanner daniellanner mentioned this issue Apr 30, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add code owner approval as attribute daniellanner/python-gitlab
1 participant
@daniellanner