Skip to content

Allow updating "forward deployment" setting #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chris-peterson opened this issue Jun 3, 2021 · 4 comments · Fixed by #1499
Closed

Allow updating "forward deployment" setting #1497

chris-peterson opened this issue Jun 3, 2021 · 4 comments · Fixed by #1499
Labels
cli

Comments

@chris-peterson
Copy link

chris-peterson commented Jun 3, 2021 •
edited
Loading

Description of the problem, including code/CLI snippet

This setting in a project's CI configuration is not currently settable via cli
image

Expected Behavior

gitlab project update --id xxxx --ci_forward_deployment_enabled false

Actual Behavior

gitlab: error: unrecognized arguments: --ci_forward_deployment_enabled false

Specifications

  • python-gitlab version: 2.7.1
  • API version you are using (v3/v4): v4
  • Gitlab server version (or gitlab.com): 13.10.3
@nejch nejch added the cli label Jun 3, 2021
@JohnVillalovos JohnVillalovos mentioned this issue Jun 3, 2021
Merged
@JohnVillalovos
Copy link
Member

As a note when things are working I believe the command line will be:

gitlab project update --id xxxx --ci-forward-deployment-enabled false

Hyphens (-) between the words instead of underscores (_).

I have proposed a patch which should add support for this.

@chris-peterson
Copy link
Author

thank you @JohnVillalovos !

good call on the - instead of _. I think I copied it from the json structure rather than existing CLI examples.

@chris-peterson
Copy link
Author

just verified the fix in 2.8.0!

gitlab project update --id 'cpeterson%2fci-test' --ci-forward-deployment-enabled false ✅

a lot of my deployment jobs are multi-regional to the same logical "environment". the default setting of true doesn't make sense -- glad to be able to change it more easily now.

thanks all 🙇

@JohnVillalovos
Copy link
Member

Glad to know it is working @chris-peterson 😊

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: sync create and update attributes for Projects
3 participants
@JohnVillalovos @chris-peterson @nejch