Skip to content

Support for Deleting Merge Request Approval Rules #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snazzyfox opened this issue Jun 29, 2021 · 0 comments · Fixed by #1888
Closed

Support for Deleting Merge Request Approval Rules #1538

snazzyfox opened this issue Jun 29, 2021 · 0 comments · Fixed by #1888
Labels
EE Issues related to the enterprise version of GitLab feature

Comments

@snazzyfox
Copy link

Description of the problem, including code/CLI snippet

Merge request approval rules were added in #1200 which implemented list, create, and update, but delete was not included for some reason. Gitlab API supports deleting these rules, so we should implement deletion for these events as well, such as

approval_rules = project.approval_rules.list()
approval_rules[0].delete()

Expected Behavior

Approval rules can be deleted.

Actual Behavior

The delete function does not exist.

Specifications

  • python-gitlab version: 2.9.0
  • API version you are using (v3/v4): v4
  • Gitlab server version (or gitlab.com): 13.12EE (the delete API has existed since at least v11)
@nejch nejch added EE Issues related to the enterprise version of GitLab feature labels Jun 30, 2021
@JohnVillalovos JohnVillalovos changed the title Support for Deleteing Merge Request Approval Rules Support for Deleting Merge Request Approval Rules Nov 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
EE Issues related to the enterprise version of GitLab feature
Projects
None yet
2 participants