-
Notifications
You must be signed in to change notification settings - Fork 670
Support rebase_in_progress #1775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the request @Predelnik. We often come to the topic of how much this library should do, and this seems to be a bit more than just wrapping the API calls. We've closed similar PRs before (e.g. #1443) because then it gets a bit blurry and we'd end up adding more and more features that aren't related to the API itself. So my first thought is that this should be handled by user code, not in the core library. On the other hand everyone would be doing this, so maybe a convenience toolkit somewhere (if not necessarily in the core library), would make sense. I'll leave it open for now, @JohnVillalovos any thoughts? |
But we should at least maybe document it the way we do for export (which is the same situation really): |
I may not understand all of this but you should be able to do:
But I did not test it so it may not work. |
Yeah, the more I think about it the more I feel this should be a custom Edit: alternatively we'd need to have a flag to make the |
I wasn't sure if @Predelnik was aware that they could pass the If they didn't know about it then maybe this information solves their problem. Unsure if they need a whole automatic thing that will sit there and wait. Personally I don't think that should be something that PG (python-gitlab) should do. Rather leave it to the consumer of the library to write the loop to wait for the status to change. |
I wasn't aware of possibility to add Also, there is a chance GitLab might themselves add |
Please let us know if it works or not. Спасибо |
Yes seems to work fine. Thank you! |
Great. I've created an MR to add some docs here: #1776 |
Uh oh!
There was an error while loading. Please reload this page.
Description of the problem, including code/CLI snippet
Rebase operation (via gitlab) is asynchronous so if for example you want to do merge afterwards there is no way if rebase is finished or not.
Expected Behavior
Possibility to check if rebase is in progress which is supported by gitlab api (see
include_rebase_in_progress
in https://docs.gitlab.com/ee/api/merge_requests.html)Actual Behavior
No way to check rebase in progress, having to rely on crude timers and so on.
I can see that in #823 it was specially left out but would it possible to support it maybe via separate function which does a request again and returns only this field maybe?
The other way is support
rebase & merge
operation as one but it might be not very flexible approach since error may happen during rebase &c.The text was updated successfully, but these errors were encountered: