Add capability to control GitLab features per project or group #1008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f4c4ef to
739666f
Compare
|
@max-wittig Could you please take a look? |
max-wittig
reviewed
Feb 7, 2020
|
@filipowm Thanks for the MR. Could you please drop the duplicate commits from master and rebase instead? |
ad2ed38 to
1ec1816
Compare
Done. I missed to notice that :) |
|
@filipowm Thanks for your efforts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently GitLab Features API supports configuring features not only globally or per user, but also per group or project.
python-gitlabis currently missing this option, thus this PR.Additionally fixed issue when setting up feature with
None(null) values, e.g. nonefeature_grouporuser. It caused GitLab to respond with HTTP 500. Thus now we're filtering outNonevalues from data.