chore: ensure developers use same gitlab image as CI #1022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nejch Thanks for the MR! I like the idea that we always pull the latest image, but I don't think we should test older versions. I'm sadly the only maintainer of this library and I don't think it's worth the time to spend on older GitLab versions. |
|
Ok sure! If you think the flag for explicit tags is helpful I can leave it, e.g. to manually run tests to check an issue is only with an old gitlab version or so (it doesn't do anything by default); otherwise I can remove it. |
|
You're right. It does make sense that it's configurable and the default is the latest! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had really weird behavior (tests failing, omnibus config wouldn't load properly) until I realized I had a super old gitlab image locally that wasn't being pulled for tests.
This does an explicit docker pull instead of
--pullsince that's only been added recently and might not work for everyone, and it should only be a tiny penalty anyway.I added a CLI flag so this should make it easy to build a CI matrix with tox that tests against several GitLab versions (e.g. latest + 3 last minor releases etc) or to explicitly test against a version reported in an issue. (Although I see currently Travis is excruciatingly slow so not sure if that's desired :D)