perf: wait for gitlab to reconfigure instead of using hardcoded sleep #1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I opened an issue on GitLab (https://gitlab.com/gitlab-org/gitlab/issues/207599) to see if there's a better way than grepping docker logs to see when a gitlab instance is fully available. :P Let's see. |
|
@nejch I really like this! Functional tests were not that reliable before. Hopefully this will be better in the long run! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw this was already tried and discussed in an older PR. I tried to use the readiness endpoint for this, but it turns out gitlab starts reporting OK on all healthchecks before it's fully reconfigured on startup (if you try
docker container logs --follow gitlab-testin another shell it'll still be restarting services when the script is already at "Pausing to give GitLab some time to finish starting up...".So it seems waiting for gitlab to report that it's reconfigured might be better. If this isn't enough for CI, then it's when gitlab logs start popping up in the container that it's 100% reliably up and running, so those could be grepped as well.
I can remove the additional log if it's too verbose, I just remember wondering if the script was hanging the first time I ran it so this gives some progress.