Skip to content

docs: fix comment of prev_page() #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2020
Merged

docs: fix comment of prev_page() #1049

merged 3 commits into from
Mar 21, 2020

Conversation

donhui
Copy link
Contributor

@donhui donhui commented Mar 18, 2020 •
edited
Loading

It shoud be prev, not next.

@donhui donhui changed the title typo fix typo fix: next --> prev Mar 20, 2020
@donhui donhui changed the title typo fix: next --> prev docs: typo fix: next --> prev Mar 20, 2020
@donhui donhui changed the title docs: typo fix: next --> prev docs: fix comment of prev_page() Mar 20, 2020
nejch
nejch requested changes Mar 21, 2020
View reviewed changes
Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @donhui, nice catch! And thanks for the commitlint fix :)

I just added 2 small suggestions (sorry for the nitpick). I think we can have the full word in the docs; as is done in https://docs.gitlab.com/ee/api/#other-pagination-headers.

donhui and others added 2 commits March 21, 2020 16:02
@donhui @nejch
docs: fix comment of prev_page()
ac6b2da 
Co-Authored-By: Nejc Habjan <hab.nejc@gmail.com>
@donhui @nejch
docs: fix comment of prev_page()
b066b41 
Co-Authored-By: Nejc Habjan <hab.nejc@gmail.com>
@donhui
Copy link
Contributor Author

donhui commented Mar 21, 2020

Thank you @donhui, nice catch! And thanks for the commitlint fix :)

I just added 2 small suggestions (sorry for the nitpick). I think we can have the full word in the docs; as is done in https://docs.gitlab.com/ee/api/#other-pagination-headers.

Thank you, I have applied your suggestions.

@nejch
Copy link
Member

nejch commented Mar 21, 2020

That was quick, thanks! I've approved but Travis is currently down for maintenance, so we just have to wait for that to go green.

If you find any more inconsistencies, feel free to open a new PR :)

@donhui
Copy link
Contributor Author

donhui commented Mar 21, 2020

OK, thanks for your review.

@nejch nejch merged commit 82deb7d into python-gitlab:master Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nejch nejch nejch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donhui @nejch