Skip to content

chore: use pytest to run unit tests and coverage #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2020
Merged

chore: use pytest to run unit tests and coverage #1066

merged 1 commit into from
Apr 8, 2020

Conversation

nejch
Copy link
Member

@nejch nejch commented Apr 7, 2020

I closed this one earlier thinking I'd include it in a later PR, but I guess it doesn't hurt to add it already, what do you think @max-wittig? :)

@nejch nejch requested a review from max-wittig April 7, 2020 21:34
@max-wittig
Copy link
Member

Doesn't hurt. That's true. Is there a way to show coverage changes in GitHub as well? I'm always missing features in Github, but that's where the community is still (and GitLab is missing a follow feature) 😄

@max-wittig max-wittig merged commit efc6182 into python-gitlab:master Apr 8, 2020
@nejch
Copy link
Member Author

nejch commented Apr 8, 2020

Doesn't hurt. That's true. Is there a way to show coverage changes in GitHub as well? I'm always missing features in Github, but that's where the community is still (and GitLab is missing a follow feature) 😄

I've been think about this as well 😄 Badges and integrations with outside providers seems to be the only way, but probably no way of having it displayed in-line in diffs like with GitLab 12.9. Some integrations like Coveralls/SonarQube and other code quality tools might at least give us PR decorations or CI checks to display a summary, we'd have to see and decide on one.

Here's one example:
image

(from TheKevJames/coveralls-python#224)

We can open a follow-up issue after some research :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants