feat(api): added support in the GroupManager to upload Group avatars #1077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nejch
reviewed
Apr 16, 2020
There was a problem hiding this comment.
@Flor1an-dev nice catch, thanks! Hard to keep up with the little details in the API sometimes it seems 😄
If you don't mind, we could also add this to the docs for Groups API like we do for Projects and users API (see example below)?
python-gitlab/docs/gl_objects/projects.rst
Lines 91 to 97 in 70cefe4
|
@nejch I've added the documentation as well :) |
Thanks again! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the
UserManagerandProjectManagertheGroupManagernow supports uploading avatar images. TheGroupManagerobject was missing theImageAttributetype.The feature to upload avatars to groups was introduced in Gitlab 12.9.
See also https://docs.gitlab.com/ce/api/groups.html#new-group (Attribute "avatar")