Added NO_ACCESS const #1108
Added NO_ACCESS const #1108
Conversation
|
Thanks for this @stuartgunter, that is useful and might pop up in other scenarios later. There have been some breaking changes in GitLab 13.0, which is why there have been some unrelated build failures recently. Could you rebase this on top of master - then this should go green? Thanks! :) |
|
kinda little nitpick on how the conventional changelog linter works. Could you begin your message in small case so that the pipeline goes green? |
This constant is useful for cases where no access is granted, e.g. when creating a protected branch. The `NO_ACCESS` const corresponds to the definition in https://docs.gitlab.com/ee/api/protected_branches.html
|
Hi @max-wittig ... no problem. I've updated the commit message. While I like the idea behind conventional changelog, it's quite an overhead for a small change like this from an infrequent contributor. I understand why it's been chosen but it has discouraged me from contributing more. If only there was a consistent contribution guide for all/most OSS projects so we could reduce the barrier to entry :( |
|
@stuartgunter That's true, but otherwise the history is gonna be a mess and you will never find any reasonable messages (everyone would just use. |
|
Thanks for the addition and sorry for the hassle |
|
No problem at all. I do understand the rationale for using conventional changelog. My comments weren't intended as criticism, and I hope they were received well. I wonder whether a pre-commit hook would help avoid having to amend commit messages and force push. That would certainly help new contributors get it right the first time and avoid too much Git-foo :) |
|
No I totally get your point and I'm annoyed by it myself that others cannot contribute that easily, but I'm not sure that having the wild west of commit messages be the better solution 😄 A pre-commit hooks would actually be very nice. Thanks for the idea. |
This constant is useful for cases where no access is granted, e.g. when creating a protected branch.
The
NO_ACCESSconst corresponds to the definition in https://docs.gitlab.com/ee/api/protected_branches.html