Skip to content

feat: add share/unshare the group with a group #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2020
Merged

feat: add share/unshare the group with a group #1139

merged 2 commits into from
Aug 21, 2020

Conversation

sathieu
Copy link
Contributor

@sathieu sathieu commented Jul 23, 2020

No description provided.

@sathieu sathieu force-pushed the share_group_with_group branch from 535f579 to 1a44086 Compare July 23, 2020 08:02
@sathieu sathieu changed the title Add Share/unshare the group with a group feat: add share/unshare the group with a group Jul 23, 2020
@sathieu sathieu force-pushed the share_group_with_group branch 3 times, most recently from 30a2d2b to b3bae48 Compare July 23, 2020 13:45
@sathieu sathieu force-pushed the share_group_with_group branch from b3bae48 to 9977799 Compare July 23, 2020 14:06
@sathieu
Copy link
Contributor Author

sathieu commented Jul 23, 2020

@max-wittig This is now ready. Please review.

@sathieu sathieu mentioned this pull request Jul 23, 2020
Closed
@sathieu
Copy link
Contributor Author

sathieu commented Aug 21, 2020

@max-wittig Please review. It also includes a commit to fix the CI.

@max-wittig
Copy link
Member

max-wittig commented Aug 21, 2020 •
edited
Loading

Thanks for the MR. Looks good! We might need to revert the CI fix commit, as GitLab has recognised the issue: https://gitlab.com/gitlab-org/gitlab/-/issues/238165

@max-wittig max-wittig merged commit cfa8097 into python-gitlab:master Aug 21, 2020
@sathieu
Copy link
Contributor Author

sathieu commented Aug 21, 2020

Thanks !

@sathieu sathieu deleted the share_group_with_group branch August 21, 2020 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sathieu @max-wittig