Skip to content

Add support to resource milestone events #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 29, 2020
Merged

Add support to resource milestone events #1157

merged 4 commits into from
Aug 29, 2020

Conversation

Shkurupii
Copy link

Closes #1154

@Shkurupii Shkurupii closed this Aug 26, 2020
@Shkurupii
Copy link
Author

Bad commit message

@Shkurupii Shkurupii reopened this Aug 26, 2020
@Shkurupii
Copy link
Author

@max-wittig take a look, please!

@max-wittig
Copy link
Member

Thanks for the MR. Could you just please add some tests to it? 👍

@Shkurupii
Copy link
Author

What kind of tests? Please, elaborate. I am using "resourcelabelevents" for a starting point, so I have added to python_test_v4.py another two tests for milestones as same as for the resourcelabelevents.

@max-wittig
Copy link
Member

You've added functional tests. Would you mind to also add some unittests here? https://github.com/python-gitlab/python-gitlab/tree/master/gitlab/tests/objects

@Shkurupii
Copy link
Author

@max-wittig Hi, check this out. Also, I can't understand why black fails my changes. WDYT? Please, advise.

@Shkurupii
Copy link
Author

@max-wittig Hi, check this out. Also, I can't understand why black fails my changes. WDYT? Please, advise.

Found out that Travis black is a higher version than mine. Add another commit to make linter happy.

max-wittig
max-wittig approved these changes Aug 29, 2020
View reviewed changes
Copy link
Member

@max-wittig max-wittig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for the black breakage. I guess it makes sense to pin the version.

Thanks for the MR!

@max-wittig max-wittig merged commit 750f4ee into python-gitlab:master Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-wittig max-wittig max-wittig approved these changes

Assignees

@Shkurupii Shkurupii

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for resource milestone events
2 participants
@Shkurupii @max-wittig