feat(api): add support for user identity provider deletion #1181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-wittig
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1070.
This one is weird because the endpoint is kind of special (only supports delete, plus the creation of identities is inconsistent with this endpoint).
https://docs.gitlab.com/ee/api/users.html#delete-authentication-identity-from-user
I couldn't do
user.identitiesfor the manager because that's the attribute returned in the nested JSON. Maybe this could be done by having a__repr__()that returns that list from the attribute of the parent manager? But it felt like I would just be adding to the inconsistency, not sure. I didn't find any other examples that solved it for nested json.I opted for
user.identityproviders.delete()since its explicit and the provider is a required param. I also considereduser.identity.delete(),user.delete_identity()(custom method) anduser.providers.delete(), I'm open to any other suggestions here 😁