Skip to content

fix(cli): write binary data to stdout buffer #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 12, 2020
Merged

fix(cli): write binary data to stdout buffer #1202

merged 4 commits into from
Oct 12, 2020

Conversation

nejch
Copy link
Member

@nejch nejch commented Oct 1, 2020

Closes #820.

@nejch nejch force-pushed the fix/cli-binary-data branch 3 times, most recently from 595f64a to 1d91413 Compare October 10, 2020 16:37
@codecov-io
Copy link

codecov-io commented Oct 10, 2020 •
edited
Loading

Codecov Report

Merging #1202 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1202   +/-   ##
=======================================
  Coverage   77.64%   77.64%           
=======================================
  Files          11       11           
  Lines        2836     2836           
=======================================
  Hits         2202     2202           
  Misses        634      634
Impacted Files Coverage Δ
gitlab/v4/cli.py 40.23% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9054a3b...f4e7950. Read the comment docs.

@nejch nejch marked this pull request as ready for review October 10, 2020 17:20
@max-wittig
Copy link
Member

@nejch Could you please rebase this MR?

@nejch nejch force-pushed the fix/cli-binary-data branch from 1d91413 to f4e7950 Compare October 12, 2020 16:29
@nejch
Copy link
Member Author

nejch commented Oct 12, 2020

@nejch Could you please rebase this MR?

👍 done :)

@nejch nejch requested a review from max-wittig October 12, 2020 18:02
@max-wittig max-wittig merged commit 3a38c6d into master Oct 12, 2020
@nejch nejch deleted the fix/cli-binary-data branch October 12, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-wittig max-wittig Awaiting requested review from max-wittig

Assignees

@nejch nejch

Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No way to download artifacts using CLI
3 participants
@nejch @codecov-io @max-wittig