Skip to content

test(users): force 10 seconds sleep to improve reliability #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

test(users): force 10 seconds sleep to improve reliability #1215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/functional/api/test_users.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def test_delete_user(gl, wait_for_sidekiq):
"password": "delete-user-pass",
}
)

time.sleep(10)
new_user.delete()
Comment on lines +57 to 58
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should go after, because the delete itself is taking too long:

Suggested change
time.sleep(10)
new_user.delete()
new_user.delete()
time.sleep(10)

Looks like we really need this. I thought my little sidekiq wait hack would work though 🤕 I based it off of this, but I'm not sure if we can extract from the API when this exact sidekiq deletion job is finished:

We can't guarantee when the user will actually be deleted by Sidekiq; this could take a while if the user has a lot of projects/events/etc.

I'll keep looking into this later, maybe we could also just wrap these asserts in retries until the condition is met (with a timeout), since it seems to me like GitLab gets more bloated with new features and so things can take longer with new releases on these little Travis VMs?

They do perform better during the day/office hours though, just retried all the jobs and they're going green 🤣

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use something like flaky for this?

wait_for_sidekiq()

Expand Down