Skip to content

feat: support multipart uploads #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2021
Merged

feat: support multipart uploads #1252

merged 1 commit into from
Jan 28, 2021

Conversation

max-wittig
Copy link
Member

@max-wittig max-wittig commented Dec 16, 2020 •
edited by nejch
Loading

Closes #1004
Closes #646

@max-wittig max-wittig force-pushed the feat/multipart-uploads branch 2 times, most recently from 69561fd to b69fdff Compare December 17, 2020 10:06
@max-wittig max-wittig force-pushed the feat/multipart-uploads branch 2 times, most recently from 544a2d8 to 5ecba1b Compare January 21, 2021 12:43
@max-wittig max-wittig mentioned this pull request Jan 28, 2021
Merged
@max-wittig max-wittig force-pushed the feat/multipart-uploads branch from 5ecba1b to 2fa3004 Compare January 28, 2021 07:46
@codecov-io
Copy link

Codecov Report

Merging #1252 (2fa3004) into master (fd179d4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1252   +/-   ##
=======================================
  Coverage   78.05%   78.05%           
=======================================
  Files          11       11           
  Lines        2866     2866           
=======================================
  Hits         2237     2237           
  Misses        629      629
Flag Coverage Δ
unit 78.05% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/__init__.py 79.71% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd179d4...2fa3004. Read the comment docs.

@max-wittig max-wittig marked this pull request as ready for review January 28, 2021 11:49
@max-wittig max-wittig requested a review from nejch January 28, 2021 11:49
@nejch nejch merged commit 4f8d901 into master Jan 28, 2021
@nejch
Copy link
Member

nejch commented Jan 28, 2021

Nice! I also closed the underlying issue for large files. I wish I had this last year when doing a bunch of imports 😁

@max-wittig max-wittig deleted the feat/multipart-uploads branch January 29, 2021 11:56
@nejch nejch mentioned this pull request May 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nejch nejch Awaiting requested review from nejch

Assignees

@nejch nejch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception: OverflowError: string longer than 2147483647 bytes
3 participants
@max-wittig @codecov-io @nejch