Skip to content

Use inline anonymous references for external links #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Use inline anonymous references for external links #1255

merged 1 commit into from
Jan 29, 2021

Conversation

bittner
Copy link
Contributor

@bittner bittner commented Dec 17, 2020

The links to "the official documentation" on tokens are currently broken in the project documentation.

There doesn't seem to be an obvious way to use an alias for identical text labels that link to different targets. With inline links we can work around this shortcoming. Until we know better.

@max-wittig
Copy link
Member

Thanks for the MR. Would you mind to change your commit message to comply with the conventional changelog?

docs(cli): use inline anonymous references for external links

@bittner
Copy link
Contributor Author

bittner commented Dec 17, 2020

Done. I left the long comment in the second line. Is that fine?

@max-wittig
Copy link
Member

Totally fine. Thanks 👍

There doesn't seem to be an obvious way to use an alias for identical
text labels that link to different targets. With inline links we can
work around this shortcoming. Until we know better.
@max-wittig
Copy link
Member

Sorry for ignoring this for so long! Thanks for your MR!

@max-wittig max-wittig merged commit 762f959 into python-gitlab:master Jan 29, 2021
@bittner bittner deleted the docs/fix-external-links-tokens branch February 7, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants