Skip to content

Enable mypy type checking and add type hints to gitlab/base.py #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 23, 2021
Merged

Enable mypy type checking and add type hints to gitlab/base.py #1299

merged 2 commits into from
Feb 23, 2021

Conversation

JohnVillalovos
Copy link
Member

Add an initial mypy test to test gitlab/base.py and gitlab/init.py

nejch
nejch reviewed Feb 16, 2021
View reviewed changes
Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @JohnVillalovos. Maybe this could be added to CI as well then, e.g. with the lint jobs:

python-gitlab/.github/workflows/lint.yml

Line 14 in bec2094

jobs:

Although the test workflows might give you an idea on how to add tox.

@codecov-io
Copy link

codecov-io commented Feb 20, 2021 •
edited
Loading

Codecov Report

Merging #1299 (abc715b) into master (2b29776) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1299      +/-   ##
==========================================
+ Coverage   80.76%   80.78%   +0.02%     
==========================================
  Files          69       69              
  Lines        3623     3628       +5     
==========================================
+ Hits         2926     2931       +5     
  Misses        697      697
Flag Coverage Δ
unit 80.78% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/base.py 83.82% <100.00%> (+0.61%) ⬆️
gitlab/client.py 80.34% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b29776...abc715b. Read the comment docs.

@JohnVillalovos JohnVillalovos changed the title RFC: feat: add an initial mypy test to tox.ini WIP: feat: add an initial mypy test to tox.ini Feb 20, 2021
@JohnVillalovos JohnVillalovos changed the title WIP: feat: add an initial mypy test to tox.ini Enable mypy type checking and add type hints to gitlab/base.py Feb 21, 2021
nejch
nejch requested changes Feb 21, 2021
View reviewed changes
Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a left a few more comments on the CI/tox setup, not sure if this is still WIP or if the file list is complete :)

@JohnVillalovos JohnVillalovos marked this pull request as draft February 21, 2021 16:35
@JohnVillalovos JohnVillalovos marked this pull request as ready for review February 21, 2021 17:30
@JohnVillalovos JohnVillalovos requested a review from nejch February 21, 2021 17:36
@JohnVillalovos
Copy link
Member Author

I think I have done all the requested changes and I believe it is ready for review now. Thanks.

nejch
nejch reviewed Feb 22, 2021
View reviewed changes
@JohnVillalovos
feat: add an initial mypy test to tox.ini
fdec039 
Add an initial mypy test to test gitlab/base.py and gitlab/__init__.py
@JohnVillalovos
chore: add type hints to gitlab/base.py
3727cbd
@JohnVillalovos
Copy link
Member Author

Rebased to fix merge conflicts

@JohnVillalovos JohnVillalovos requested a review from nejch February 23, 2021 01:10
@nejch nejch merged commit a18bc5c into python-gitlab:master Feb 23, 2021
@JohnVillalovos
Copy link
Member Author

Woo hoo, merged! 🙂

Thanks!

@JohnVillalovos JohnVillalovos deleted the mypy branch February 24, 2021 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nejch nejch nejch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnVillalovos @codecov-io @nejch