Skip to content

fix: test_update_group() dependency on ordering #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2021
Merged

fix: test_update_group() dependency on ordering #1311

merged 1 commit into from
Feb 21, 2021

Conversation

JohnVillalovos
Copy link
Member

Since there are two groups we can't depend on the one we changed to
always be the first one returned.

Instead fetch the group we want and then test our assertion against
that group.

Since there are two groups we can't depend on the one we changed to
always be the first one returned.

Instead fetch the group we want and then test our assertion against
that group.
@codecov-io
Copy link

Codecov Report

Merging #1311 (e78a8d6) into master (649385c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1311   +/-   ##
=======================================
  Coverage   80.67%   80.67%           
=======================================
  Files          68       68           
  Lines        3607     3607           
=======================================
  Hits         2910     2910           
  Misses        697      697           
Flag Coverage Δ
unit 80.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 649385c...e78a8d6. Read the comment docs.

@nejch
Copy link
Member

nejch commented Feb 21, 2021

Since there are two groups we can't depend on the one we changed to
always be the first one returned.

Instead fetch the group we want and then test our assertion against
that group.

Thanks, this will fix a lot of the flakiness.

There's probably some more weirdness and unnecessary dependency on execution order in functional tests, because they were rewritten from a single module with plain asserts. I'll try to get to that at some point.

@nejch nejch merged commit 3381700 into python-gitlab:master Feb 21, 2021
@JohnVillalovos JohnVillalovos deleted the jlvillal/fix_functional branch February 21, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants