Skip to content

feat: add release links API support #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 21, 2021
Merged

feat: add release links API support #1314

merged 4 commits into from
Feb 21, 2021

Conversation

nejch
Copy link
Member

@nejch nejch commented Feb 21, 2021

Closes #1297

This splits a few things out:

  • releases from tags.py into own module and adds release links
  • releases from projects.rst into own module in the docs as well
  • release functional tests from projects into own module, and adds a link test

Also made Project refreshable for convenience in functional tests but kept in a separate commit just in case (see #1313)

@codecov-io
Copy link

Codecov Report

Merging #1314 (36d65f0) into master (649385c) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1314      +/-   ##
==========================================
+ Coverage   80.67%   80.76%   +0.08%     
==========================================
  Files          68       69       +1     
  Lines        3607     3623      +16     
==========================================
+ Hits         2910     2926      +16     
  Misses        697      697              
Flag Coverage Δ
unit 80.76% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/tags.py 63.88% <ø> (-5.88%) ⬇️
gitlab/v4/objects/__init__.py 100.00% <100.00%> (ø)
gitlab/v4/objects/projects.py 69.20% <100.00%> (+0.11%) ⬆️
gitlab/v4/objects/releases.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 649385c...36d65f0. Read the comment docs.

@nejch nejch marked this pull request as ready for review February 21, 2021 12:16
@nejch nejch requested a review from max-wittig February 21, 2021 12:16
@max-wittig max-wittig merged commit 2b29776 into master Feb 21, 2021
@max-wittig max-wittig deleted the feat/release-links branch February 21, 2021 12:31
@max-wittig
Copy link
Member

Thanks for the PR!

@hubidubi13
Copy link

Awesome! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Release Links to the API
4 participants