fix: undefined name errors #1322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discovered that there were some undefined names.
Codecov Report
@@ Coverage Diff @@
## master #1322 +/- ##
=======================================
Coverage 80.25% 80.25%
=======================================
Files 71 71
Lines 3738 3738
=======================================
Hits 3000 3000
Misses 738 738
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nejch
approved these changes
Feb 23, 2021
I ran flake8 locally after doing the patch to remove the 'import *' lines. And found these missing names. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered that there were some undefined names.