Skip to content

chore: add and fix some type-hints in gitlab/client.py #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2021
Merged

chore: add and fix some type-hints in gitlab/client.py #1343

merged 1 commit into from
Feb 28, 2021

Conversation

JohnVillalovos
Copy link
Member

@JohnVillalovos JohnVillalovos commented Feb 27, 2021 •
edited
Loading

Was able to figure out better type-hints for gitlab/client.py

@JohnVillalovos JohnVillalovos changed the title DNM: testing things chore: add and fix some type-hints in gitlab/client.py Feb 27, 2021
@JohnVillalovos
chore: add and fix some type-hints in gitlab/client.py
8837207 
Was able to figure out better type-hints for gitlab/client.py
nejch
nejch approved these changes Feb 28, 2021
View reviewed changes
Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks like all method returns are now covered in client.py.

@nejch nejch merged commit f5a65f0 into python-gitlab:master Feb 28, 2021
@JohnVillalovos JohnVillalovos deleted the jlvillal/mypy_testing_things branch February 28, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nejch nejch nejch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnVillalovos @nejch