Skip to content

chore: add type hints to gitlab/base.py:RESTManager #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2021
Merged

chore: add type hints to gitlab/base.py:RESTManager #1353

merged 1 commit into from
Mar 6, 2021

Conversation

JohnVillalovos
Copy link
Member

Add some additional type hints to gitlab/base.py

Add some additional type hints to gitlab/base.py
@codecov-io
Copy link

Codecov Report

Merging #1353 (9c55593) into master (96d2805) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1353      +/-   ##
==========================================
+ Coverage   80.21%   80.23%   +0.02%     
==========================================
  Files          73       73              
  Lines        3801     3805       +4     
==========================================
+ Hits         3049     3053       +4     
  Misses        752      752              
Flag Coverage Δ
unit 80.23% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/base.py 84.66% <100.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96d2805...9c55593. Read the comment docs.

@nejch nejch merged commit ebdfec7 into python-gitlab:master Mar 6, 2021
@JohnVillalovos JohnVillalovos deleted the jlvillal/mypy_base branch March 14, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants