Skip to content

feat: add support for resource state events API #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 18, 2021
Merged

feat: add support for resource state events API #1364

merged 4 commits into from
Apr 18, 2021

Conversation

nejch
Copy link
Member

@nejch nejch commented Mar 7, 2021

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 7, 2021 •
edited
Loading

Codecov Report

Merging #1364 (40eb59e) into master (48fc907) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1364      +/-   ##
==========================================
+ Coverage   79.92%   80.00%   +0.07%     
==========================================
  Files          73       73              
  Lines        4010     4020      +10     
==========================================
+ Hits         3205     3216      +11     
+ Misses        805      804       -1
Flag Coverage Δ
unit 80.00% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/issues.py 80.88% <ø> (ø)
gitlab/v4/objects/merge_requests.py 65.45% <ø> (ø)
gitlab/v4/objects/events.py 100.00% <100.00%> (ø)
gitlab/mixins.py 77.77% <0.00%> (-0.16%) ⬇️
gitlab/v4/cli.py 40.40% <0.00%> (+0.16%) ⬆️
gitlab/base.py 84.86% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48fc907...40eb59e. Read the comment docs.

@nejch nejch force-pushed the feat/resource-state-events branch from 2ad239a to 40eb59e Compare March 8, 2021 08:12
max-wittig
max-wittig reviewed Mar 24, 2021
View reviewed changes
max-wittig
max-wittig requested changes Mar 24, 2021
View reviewed changes
Copy link
Member

@max-wittig max-wittig left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some little typos

@nejch nejch force-pushed the feat/resource-state-events branch from 40eb59e to c5e6fb3 Compare April 18, 2021 12:43
@codecov-commenter
Copy link

Codecov Report

Merging #1364 (c5e6fb3) into master (af781c1) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1364      +/-   ##
==========================================
+ Coverage   80.10%   80.16%   +0.05%     
==========================================
  Files          73       73              
  Lines        4061     4073      +12     
==========================================
+ Hits         3253     3265      +12     
  Misses        808      808
Flag Coverage Δ
unit 80.16% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/issues.py 80.88% <ø> (ø)
gitlab/v4/objects/merge_requests.py 65.45% <ø> (ø)
gitlab/v4/objects/events.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af781c1...c5e6fb3. Read the comment docs.

@nejch nejch assigned max-wittig and unassigned max-wittig and nejch Apr 18, 2021
@max-wittig max-wittig merged commit 916a7fe into master Apr 18, 2021
@nejch nejch mentioned this pull request May 26, 2021
Closed
@nejch nejch deleted the feat/resource-state-events branch May 30, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-wittig max-wittig max-wittig requested changes

Assignees

@max-wittig max-wittig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nejch @codecov-io @codecov-commenter @max-wittig