Skip to content

Improvements to HTTP requests #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Conversation

bbatliner
Copy link
Contributor

Two related commits that fixed #1386 for me. Only the first commit is strictly necessary. The second is a "technically correct" fix so that http_request does not send extra query parameters.

Some arguments to `http_request` were being read
from kwargs, but kwargs is where this function
creates query parameters from, by default. In
the absence of a `query_parameters` param, the
function would construct URLs with query
parameters such as `retry_transient_errors=True`
despite those parameters having no meaning to
the API to which the request was sent.

This change names those arguments that are
specific to `http_request` so that they do not
end up as query parameters read from kwargs.
@max-wittig
Copy link
Member

That's much nicer. Thanks 👍

@max-wittig max-wittig merged commit cfc42d2 into python-gitlab:master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request URL is getting too long because of query_parameters
3 participants