fix: correct some type-hints in gitlab/mixins.py #1398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit baea721 introduced type-hints for gitlab/mixins.py. After starting to add type-hints to gitlab/v4/objects/users.py discovered a few errors. Main error was using '=' instead of ':'. For example: _parent = Optional[...] should be _parent: Optional[...] Resolved those issues.
Codecov Report
@@ Coverage Diff @@
## master #1398 +/- ##
==========================================
- Coverage 80.16% 80.13% -0.03%
==========================================
Files 73 73
Lines 4073 4077 +4
==========================================
+ Hits 3265 3267 +2
- Misses 808 810 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Thanks for the fixes. That makes much more sense now 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit baea721 introduced type-hints
for gitlab/mixins.py.
After starting to add type-hints to gitlab/v4/objects/users.py
discovered a few errors.
Main error was using '=' instead of ':'. For example:
_parent = Optional[...] should be _parent: Optional[...]
Resolved those issues.