Skip to content

chore(objects): remove noisy deprecation warning for audit events #1414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2021

Conversation

nejch
Copy link
Member

@nejch nejch commented Apr 25, 2021

When I added this in #1363 I missed that it always gets instantiated and everyone will be getting the warning. It's mostly an internal thing anyway and can be removed in 3.0.0.

Needed for 2.7.0 #1408 so people don't get spammed 😁

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2021

Codecov Report

Merging #1414 (2953642) into master (4f79dff) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1414      +/-   ##
==========================================
- Coverage   80.20%   80.17%   -0.03%     
==========================================
  Files          73       73              
  Lines        4067     4061       -6     
==========================================
- Hits         3262     3256       -6     
  Misses        805      805              
Flag Coverage Δ
unit 80.17% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/audit_events.py 100.00% <ø> (ø)
gitlab/client.py 78.96% <100.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfc42d2...2953642. Read the comment docs.

It's mostly an internal thing anyway and can be removed in 3.0.0
@nejch nejch force-pushed the chore/remove-noisy-deprecation-warning branch from 5453c60 to 2953642 Compare April 25, 2021 12:31
@max-wittig max-wittig merged commit 0a0fcaf into master Apr 25, 2021
@nejch nejch deleted the chore/remove-noisy-deprecation-warning branch May 30, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants