Skip to content

fix(files): do not url-encode filepaths twice #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2021
Merged

fix(files): do not url-encode filepaths twice #1418

merged 1 commit into from
Apr 26, 2021

Conversation

nejch
Copy link
Member

@nejch nejch commented Apr 26, 2021

Closes #1416.

This is a quick fix for 2.7.0 but we should clean up with #1356 eventually :)

@max-wittig
Copy link
Member

@nejch Thanks for the fix! I will push out a release right after the pipeline passes 👍

@max-wittig max-wittig merged commit 37af229 into master Apr 26, 2021
@max-wittig max-wittig deleted the fix/urlencode-file-paths branch April 26, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@max-wittig max-wittig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2.7.0 breaks when trying to get pathed files
2 participants
@nejch @max-wittig