Fix JIRA service - add api_url to mandatory attributes #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The api_url attribute is mandatory at least since GitLab 8.11. Otherwise server returns gitlab.exceptions.GitlabUpdateError: 400: 400 (Bad request) "api_url" not given.
|
Thank you for the patch. I'd rather define this parameter as optional, to keep compatibility with older versions of Gitlab. I know it's not optimal but I don't have a solution to handle multiple APIs in multiple Gitlab versions at the moment. |
|
@gpocentek sounds good to me. Closing this pull request. Thanks! |
|
@galet you can update this pull request if you still want to submit the change. |
- move api_url to optional attributes based on comments in
python-gitlab#142 (comment)
|
Created a new clean pull request #146. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
api_urlattribute is mandatory at least since GitLab 8.11. Otherwise server returnsgitlab.exceptions.GitlabUpdateError: 400: 400 (Bad request) "api_url" not given.