Codecov Report

Merging #1429 (7160935) into master (98891eb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1429   +/-   ##
=======================================
  Coverage   80.24%   80.24%           
=======================================
  Files          73       73           
  Lines        4064     4064           
=======================================
  Hits         3261     3261           
  Misses        803      803           

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98891eb...7160935. Read the comment docs.

Nice catch!

Do we need to assign variables that we're not using to _?

No. The only reason I had for doing that was to make it clear that the call returns something.

I was undecided if I should just delete the assignment or use _. So I went with _ 😀

But I will re-do it and delete the assignments.

If we want to check, if it's returning something we should assert instead. But I think this is already checked somewhere else.

You can also apply the suggestions and I squash after, if you like 😃

@max-wittig Updated. I think I have changed everything as requested.