Skip to content

fix(objects): return server data in cancel/retry methods #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2021

Conversation

nejch
Copy link
Member

@nejch nejch commented May 2, 2021

Closes #825. It seems like it's something people want and saves a few extra API calls in some cases.

@codecov-commenter
Copy link

Codecov Report

Merging #1444 (9fed061) into master (b563cdc) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1444      +/-   ##
==========================================
+ Coverage   80.24%   80.45%   +0.21%     
==========================================
  Files          73       73              
  Lines        4064     4073       +9     
==========================================
+ Hits         3261     3277      +16     
+ Misses        803      796       -7     
Flag Coverage Δ
unit 80.45% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/jobs.py 70.68% <100.00%> (+6.89%) ⬆️
gitlab/v4/objects/pipelines.py 93.33% <100.00%> (+5.33%) ⬆️
gitlab/types.py 90.00% <0.00%> (-2.60%) ⬇️
gitlab/exceptions.py 96.52% <0.00%> (-1.30%) ⬇️
gitlab/__main__.py 0.00% <0.00%> (ø)
gitlab/cli.py 56.36% <0.00%> (+2.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b563cdc...9fed061. Read the comment docs.

@max-wittig max-wittig enabled auto-merge May 2, 2021 17:55
Copy link
Member

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@max-wittig max-wittig merged commit 1ddb54a into master May 2, 2021
@max-wittig max-wittig deleted the fix/return-retry-cancel-output branch May 2, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Job retry method should return created job
4 participants